External network members endpoints - #302
Draft
iljarotar wants to merge 39 commits into
Draft
Conversation
…ternal-network-members-endpoints
metal-robot
Bot
added
the
area: control-plane
iljarotar
marked this pull request as ready for review
September 2, 2026 09:35
This reverts commit 8b81e9c.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 79.95% 80.06% +0.11%
==========================================
Files 199 200 +1
Lines 14811 15066 +255
==========================================
+ Hits 11842 12063 +221
- Misses 2968 3002 +34
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
majst01
reviewed
Sep 2, 2026
majst01
approved these changes
Sep 2, 2026
majst01
reviewed
Sep 2, 2026
majst01
reviewed
Sep 4, 2026
majst01
reviewed
Sep 8, 2026
| } | ||
| } | ||
|
|
||
| // FIXME: shouldn't we return an error if a machine sees a neighbor but we can't find the nic on the switch? |
Contributor
There was a problem hiding this comment.
might be a good issue to work on at a later point in time
| continue | ||
| } | ||
|
|
||
| if nic.Vrf != fmt.Sprintf("Vrf%d", nw.Vrf) { |
Contributor
There was a problem hiding this comment.
if this fmt.Sprintf happens more offen, it could be useful to have a Stringer() func on the Vrf
iljarotar
marked this pull request as draft
September 9, 2026 08:30
iljarotar
force-pushed
the
external-network-members-endpoints
branch
from
September 9, 2026 14:52
1f08069 to
d28ab79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements endpoints for external network members. An external member is a host that is connected to one of our racks but is not itself registered at the api.
depends on metal-stack/api#188
TODO
Some issues remain: